Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

Test firmware build ready — commit 401a9c8

Download firmware for PR #11664

238 targets built. Find your board's .hex file by name on that page (e.g. MATEKF405SE.hex). Files are individually downloadable — no GitHub login required.

Development build for testing only. Use Full Chip Erase when flashing.

Cool. I would have guessed that to disable, you'd say it should take at least 0 milliseconds. Zero to disable.
Any intuition behind 100 milliseconds means disabled?

Cool. I would have guessed that to disable, you'd say it should take at least 0 milliseconds. Zero to disable. Any intuition behind 100 milliseconds means disabled?

Just down to throttleRateLimit being a uint16_t which overflows if the setting is less than something around 15 ms. Given that a setting < 100ms isn't going to have much affect on the throttle, 100ms seemed like a practical minimum to use. You could use a uint32_t instead but why bother when there's no real benefit.

Just down to throttleRateLimit being a uint16_t which overflows if the setting is less than something around 15 ms.

Oh, smart people stuff. I'm not going to remember that if I ever touch this code, and I'm going to break it.
What would happen if we changed:

static EXTENDED_FASTRAM uint16_t throttleRateLimit = 0;

To:

static EXTENDED_FASTRAM float throttleRateLimit = 0.0f;

Would that do the cast just once rather than casting every time the computation is done?

Don't forget PG version and maybe consider putting the new field at the end for bonus safety, unless putting it in the middle improves alignment.

Would that do the cast just once rather than casting every time the computation is done?

Makes sense, I'll change it.